-- fixed issue with timesheet_tasks (email vs. id)

improved readability and notifications messages

-- fixed issue with timesheet_tasks (email vs. id)
improved readability and notifications messages
12ac14fe · Frank Bergmann · e3382747 · 12ac14fe
Commit 12ac14fe authored Nov 04, 2016 by Frank Bergmann
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 4 deletions

intranet-project-reminders-procs.tcl tcl/intranet-project-reminders-procs.tcl +9 -4

No files found.
--- a/tcl/intranet-project-reminders-procs.tcl
+++ b/tcl/intranet-project-reminders-procs.tcl
@@ -209,7 +209,7 @@ ad_proc -private im_project_reminders_send_notification_to_object_members {
                	u.user_id
    	    "
 	    db_foreach r $sql {
-		lappend parties_to_be_notified_id $email
+		lappend parties_to_be_notified_id $user_id
 	    }

 	}
@@ -225,11 +225,16 @@ ad_proc -private im_project_reminders_send_notification_to_object_members {
    # Set mail attributes 
    switch $object_type {
        "im_trans_task" {
-	    set mail_body_txt "Planned end date of task: <br/>$object_name <br/> of project: <br/><a href='/intranet-translation/trans-tasks/task-list?project_id=$parent_object_id&view_name=trans_tasks'>$parent_object_name</a><br/>"
+	    set mail_body_txt "Planned end date of task: <br/>$object_name <br/> of project: <br/>"
+            append mail_body_txt "&nbsp;&nbsp;&nbsp;&nbsp;<a href='/intranet-translation/trans-tasks/task-list?project_id=$parent_object_id&view_name=trans_tasks'>$parent_object_name</a><br/>"
 	    append mail_body_txt "will be reached shortly and task has not been marked as DONE yet.<br/>Please review."	    
 	}
        "im_timesheet_task" {
-	    set mail_body_txt "Planned end date of task: <br/><a href='/intranet/projects/view?project_id=$object_id'>$object_name<br/> of project: <br/>$parent_object_name<br/> will be reached shortly and task has not been marked as DONE yet.<br/>Please review."
+	    set mail_body_txt "Planned end date of task: <br/>"
+            append mail_body_txt "&nbsp;&nbsp;&nbsp;&nbsp;<a href='/intranet/projects/view?project_id=$object_id'>$object_name</a><br/>"
+	    append mail_body_txt "of project:<br/>"
+            append mail_body_txt "&nbsp;&nbsp;&nbsp;&nbsp;<a href='/intranet/projects/view?project_id=$parent_object_id'>$parent_object_name</a><br/>" 
+            append mail_body_txt "will be reached shortly and task has not been marked as DONE yet.<br/>Please review."
 	}
        default {
            ns_log Notice "im_project_reminders_send_notification_to_object_members: Exit - object_type: $object_type not supported"
@@ -239,7 +244,7 @@ ad_proc -private im_project_reminders_send_notification_to_object_members {

    set mail_subject [lang::message::lookup "" intranet-project-reminders.Mail_Subject_Text "Friendly Reminder - Task is due soon "]   

-    set mail_body "<html>"
+    set mail_body    "<html>"
    append mail_body "<head><meta charset=\"utf-8\"></head>"
    append mail_body "<body>"
    append mail_body [lang::message::lookup "" intranet-project-reminders.Mail_Body_Text_Html $mail_body_txt]